search

xcarpentier / react-native-country-picker-modal

🇦🇶 Country picker provides a modal allowing a user to select a country from a list. It display a flag next to each country name.
https://reactnative.gallery/xcarpentier/country-picker
MIT License
1.08k stars 802 forks source link

Filter placeholder translation #394

Closed jsaq007 closed 3 years ago

jsaq007 commented 3 years ago

Issue Description

When setting a new language the filter placeholder should also be translated

Steps to Reproduce / Code Snippets

Add the withFilter prop and see the placeholder at the top it is hardcoded in English

Expected Results

When changing the my device language the placeholder text should have the same language as the counties in the list below

Additional Information

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

m-deacon commented 2 years ago

Hi @xcarpentier

Any update on this? Busy localizing my app and this is one the last strings I'm unable to localise. Even allowing a prop to overwrite this label will help and I'll add the translations to my language files.

tforkmann commented 1 year ago

Hi thank you for this cool library. We also would like to have the filter placeholder translated. Any pointers where to start? Would like to contribute. Thanks, Tim