search

xcarpentier / react-native-country-picker-modal

🇦🇶 Country picker provides a modal allowing a user to select a country from a list. It display a flag next to each country name.
https://reactnative.gallery/xcarpentier/country-picker
MIT License
1.07k stars 796 forks source link

Extend CountryPickerProps to fix missing types #461

Closed SMJ93 closed 1 year ago

SMJ93 commented 2 years ago

Some of the CountryPicker props are missing from the type definition. e.g. closeButtonStyle and closeButtonImage:

Screenshot 2022-02-28 at 16 16 35

Instead of defining the types twice (Props in src/index.tsx and CountryPickerProps in src/CountryPicker.tsx we can extend CountryPickerProps and add the theme and translation prop types:

interface Props extends CountryPickerProps {
  theme?: Theme
  translation?: TranslationLanguageCode
}
SMJ93 commented 2 years ago

@xcarpentier can this be merged?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SMJ93 commented 2 years ago

@xcarpentier can this be merged?

SMJ93 commented 1 year ago

Closing as repository is no longer maintained