search

xcarpentier / react-native-country-picker-modal

🇦🇶 Country picker provides a modal allowing a user to select a country from a list. It display a flag next to each country name.
https://reactnative.gallery/xcarpentier/country-picker
MIT License
1.07k stars 795 forks source link

fix(service): fixing sorting when using preferred countries #487

Open mateoguzmana opened 1 year ago

mateoguzmana commented 1 year ago

When using the preferredCountries prop, the alphabetic sorting is not applied, you can notice by seeing for example Kiribati and Hong Kong at the bottom of the list.

Before After
Simulator Screen Shot - iPhone 13 - 2022-09-21 at 11 15 08 After
mateoguzmana commented 1 year ago

@xcarpentier if you can take a look would be appreciated. Amazing library BTW :)

carkod commented 1 year ago

Your Circle CI is failing, have you managed to figure out anything, it's also happening to my PR