xcarpentier / react-native-country-picker-modal

🇦🇶 Country picker provides a modal allowing a user to select a country from a list. It display a flag next to each country name.
https://reactnative.gallery/xcarpentier/country-picker
MIT License
1.07k stars 795 forks source link

Emoji flags in the modal are transparent on Android #513

Open trooperandz opened 1 year ago

trooperandz commented 1 year ago

Issue Description

Emoji flags in the country picker modal are transparent on Android (not an issue on iOS). Note: this issue was previously opened, but it was closed and was never fixed/resolved in the codebase.

Without change: Screenshot_20230729_120545_DV Direct

With suggested change: Screenshot_20230729_120520_DV Direct

Steps to Reproduce / Code Snippets

On Android, render the country picker modal as described exactly in the documentation, with the emoji flags showing (the withEmoji value is true by default). Observe that the emoji flags in the modal have significant transparency, even before any press event is executed.

On iOS, render the country picker modal, same as above. Observe that the emoji flags do not have any transparency unless the press event is executed.

Adding a color style property to the emojiFlag style block in Flag.js fixes the issue:

Screenshot 2023-07-29 at 12 06 30 PM

Expected Results

On Android, the emoji flags in the country picker modal should not have any transparency until the press event occurs.

Additional Information

shravanbaghel commented 10 months ago

Can I be assigned for this?