search

xcash / bootstrap-autocomplete

Bootstrap Autocomplete
MIT License
168 stars 72 forks source link

tab keyup behavior -- issue #114 #128

Open machinehum opened 3 years ago

machinehum commented 3 years ago

Change to not break standard HTML form tab key navigation behavior. DOES NOT affect using tab key to confirm selections in dropdown (that happens in the keydown event starting at line 209), only prevents tabbing between fields from firing search events via this switch's default clause.

Justification: The user does not expect a search to happen and a dropdown to show up for a field they've already tabbed away from, or for a search to happen on the pre-existing value for a field that they tab into. This fundamentally breaks standard browser behavior, and causes accessibility issues.

xcash commented 3 years ago

Hi @machinehum and thanks for the PR. I'm currently on holiday so I can't check that everything is working correctly. All the new work I'm doing is on branch xcash-v300 with BS5 support. I think your PR will still work on that branch, would you please test it?

Thanks a lot :)