Closed whowutwut closed 7 years ago
It is more pervasive than that. It appears ipmi.pm does not do any parameter/flag verification for rspconfig
.
For example, the following does not display any error messages and returns RC=0:
[root@stratton01 ~]# rspconfig briggs01 whyisthisok
[root@stratton01 ~]# echo $?
0
[root@stratton01 ~]# rspconfig briggs01 -x
[root@stratton01 ~]# echo $?
0
[root@stratton01 ~]# rspconfig briggs01 whyisthisok=help
[root@stratton01 ~]# echo $?
0
[root@stratton01 ~]#
Ah ok. So maybe we should first fix the parsing?
If this has not been supported on OpenPower IPMI, maybe we should disable it, if possible.
I think this issue can be closed now. Tried it on the latest build 08/23/2017 and this problem somehow got fixed:
[root@stratton01 xCAT_plugin]# rspconfig briggs01 whyisthisok
Unsupported command: rspconfig whyisthisok
[root@stratton01 xCAT_plugin]# echo $?
1
[root@stratton01 xCAT_plugin]#
[root@stratton01 xCAT_plugin]# rspconfig briggs01 sshcfg
Unsupported command: rspconfig sshcfg
[root@stratton01 xCAT_plugin]# echo $?
1
[root@stratton01 xCAT_plugin]#
[root@stratton01 xCAT_plugin]# rspconfig briggs01 -x
Unsupported command: rspconfig -x
[root@stratton01 xCAT_plugin]# echo $?
1
[root@stratton01 xCAT_plugin]#
[root@stratton01 xCAT_plugin]# rspconfig briggs01 whyisthisok=help
Unsupported command: rspconfig whyisthisok=help
[root@stratton01 xCAT_plugin]# echo $?
1
[root@stratton01 xCAT_plugin]#
Thanks @gurevichmark ..!
Running command:
The OpenPower BMC user is sysadmin... and Trying to log in, prompts password..
If we don't support this, should we at least block the option? Bug/Feature?