xcat2 / xcat-core

Code repo for xCAT core packages
Eclipse Public License 1.0
361 stars 171 forks source link

rspconfig sshcfg does not work for OpenPower P8 servers #3446

Closed whowutwut closed 7 years ago

whowutwut commented 7 years ago

Running command:

[root@fs3 common]# rspconfig mid05tor12cn07 sshcfg
[root@fs3 common]#

The OpenPower BMC user is sysadmin... and Trying to log in, prompts password..

[root@fs3 common]# ssh sysadmin@172.21.140.7
sysadmin@172.21.140.7's password:

BusyBox v1.13.2 (2017-04-19 11:37:24 CDT) built-in shell (ash)
Enter 'help' for a list of built-in commands.

# exit

If we don't support this, should we at least block the option? Bug/Feature?

gurevichmark commented 7 years ago

It is more pervasive than that. It appears ipmi.pm does not do any parameter/flag verification for rspconfig. For example, the following does not display any error messages and returns RC=0:

[root@stratton01 ~]# rspconfig briggs01 whyisthisok
[root@stratton01 ~]# echo $?
0

[root@stratton01 ~]# rspconfig briggs01 -x
[root@stratton01 ~]# echo $?
0

[root@stratton01 ~]# rspconfig briggs01 whyisthisok=help
[root@stratton01 ~]# echo $?
0

[root@stratton01 ~]#
whowutwut commented 7 years ago

Ah ok. So maybe we should first fix the parsing?

If this has not been supported on OpenPower IPMI, maybe we should disable it, if possible.

gurevichmark commented 7 years ago

I think this issue can be closed now. Tried it on the latest build 08/23/2017 and this problem somehow got fixed:

[root@stratton01 xCAT_plugin]# rspconfig briggs01 whyisthisok
Unsupported command: rspconfig whyisthisok
[root@stratton01 xCAT_plugin]# echo $?
1
[root@stratton01 xCAT_plugin]#
[root@stratton01 xCAT_plugin]# rspconfig briggs01 sshcfg
Unsupported command: rspconfig sshcfg
[root@stratton01 xCAT_plugin]# echo $?
1
[root@stratton01 xCAT_plugin]#
[root@stratton01 xCAT_plugin]# rspconfig briggs01 -x
Unsupported command: rspconfig -x
[root@stratton01 xCAT_plugin]# echo $?
1
[root@stratton01 xCAT_plugin]#
[root@stratton01 xCAT_plugin]# rspconfig briggs01 whyisthisok=help
Unsupported command: rspconfig whyisthisok=help
[root@stratton01 xCAT_plugin]# echo $?
1
[root@stratton01 xCAT_plugin]#
whowutwut commented 7 years ago

Thanks @gurevichmark ..!