Open mattaezell opened 7 years ago
Thanks for taking this one @bybai. Maybe this should be a separate issue, but the current algorithm is quite slow when you have a lot of hosts. addnode
cycles through every line in the hosts file for every node defined in xCAT, for a computational complexity of O(n^2). If you end up re-working how addnode
works, please consider using a hash to improve performance.
hi @mattaezell , thanks your feedback, I open #4082 to trace improve performance for makehosts.
Our xCAT tables have a regex that overlaps with another node that we defined. I would expect this to generate a warning if the same line was modified multiple times in the same invocation (to help identify duplicates).