search

xcat2 / xcat-inventory

An inventory tool for xcat cluster
8 stars 16 forks source link

xcat-inventory import support multiple keys object passwd #138

Closed bybai closed 6 years ago

bybai commented 6 years ago

Task: xcat-inventory import support multiple keys object passwd. column 'key' and 'username' are keys for passwd table. In the past, 'key' as passwd object name. In this enhancement:

  1. passwd object name is 'key'.'username'.
  2. In passwd table, 'key' can not be empty, 'username' can be empty. So when import passwd object, the valid object names are 'key'.'username', if import object name like 'key' or 'key.', will set 'username' as ''.
zet809 commented 6 years ago

hi, @bybai , I suppose this task is similar with #86 , am I right?

bybai commented 6 years ago

Hi @zet809, #86 is about xcat-inventory export... functions, in order to support multiple keys, xcat-inventory import ... functions should be supported too. so this task is about to xcat-inventory import .. part. Thanks.

immarvin commented 6 years ago

hi @bybai , i will cover the import part in new PR

bybai commented 6 years ago

Since PR #138 have some conflicts, fix will be included in new PR by @immarvin.

immarvin commented 6 years ago

covered in PR https://github.com/xcat2/xcat-inventory/pull/142