xcatliu / pagic

A static site generator powered by Deno + React
https://pagic.org
MIT License
1.64k stars 104 forks source link

Clicking a file link in sidebar makes the main content disappear #72

Closed x87 closed 3 years ago

x87 commented 3 years ago

Describe the bug Clicking a link to the file in sidebar makes the page unresponsive (there is a spinner that never disappears). This feature was added in #71

To Reproduce In pagic.config.tsx add a new entry in the sidebar config:

            {
              text: 'Download',
              link: 'classes.db'
            }

where classes.db is a local file. Deploy the site and click the Download link. The browsers starts downloading the file and at the same time the main content is replaced with a spinner that never goes away. All links become unresponsive.

Expected behavior Clicking Download link starts file downloading. The rest of the site is not affected.

Screenshots pagic bug

It can be seen live here: https://sannybuilder.github.io/classes/

Context

xcatliu commented 3 years ago

Please try v1.1.1

x87 commented 3 years ago

@xcatliu thanks, it works!