xceedsoftware / wpftoolkit

All the controls missing in WPF. Over 1 million downloads.
Other
3.9k stars 877 forks source link

Propertygrid user input data validation issue #1772

Open gitfreshfish opened 8 months ago

gitfreshfish commented 8 months ago

question1: [Range()] causes the UI to have no user error prompts //test example as follow: using System; using System.Collections.Generic; using System.ComponentModel; using System.ComponentModel.DataAnnotations; using System.Linq; using System.Runtime.CompilerServices; namespace WpfApp1 { public class Person: INotifyPropertyChanged, IDataErrorInfo { [Required(ErrorMessage = "Name is Required")] [DisplayName("Name")] public string Name { set; get; }

    [Range(0,150,ErrorMessage = "Age= 0~150")]
    [DisplayName("Age")]
    public int Age { set; get; }

    public event PropertyChangedEventHandler? PropertyChanged;

    [Browsable(false)]
    public string Error { get; }

    public  string this[string propertyName]
    {
        get
        {
            if (string.IsNullOrEmpty(propertyName))
            {
                throw new ArgumentException("Invalid property name", propertyName);
            }
            string error = string.Empty;
            var val = GetType().GetProperty(propertyName).GetValue(this, null);

            var results = new List<System.ComponentModel.DataAnnotations.ValidationResult>(1);
            var result = Validator.TryValidateProperty(val, new ValidationContext(this, null, null)
                { MemberName = propertyName }, results);
            if (!result)
            {
                var validationResult = results.First();
                error = validationResult.ErrorMessage;
            }

            return error;
        }
    }

    protected void RaisePropertyChanged([CallerMemberName] string propertyName = null) => this.OnPropertyChanged(new PropertyChangedEventArgs(propertyName));

    protected virtual void OnPropertyChanged(PropertyChangedEventArgs args)
    {
        PropertyChangedEventHandler propertyChanged = this.PropertyChanged;
        if (propertyChanged == null)
            return;
        propertyChanged((object)this, args);
    }
}

}

<Window x:Class="WpfApp1.PropertyGrid" xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:d="http://schemas.microsoft.com/expression/blend/2008" xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:local="clr-namespace:WpfApp1" xmlns:xctk="http://schemas.xceed.com/wpf/xaml/toolkit" mc:Ignorable="d" Title="PropertyGrid" Height="450" Width="800" WindowStartupLocation="CenterScreen">

private void PropertyGrid_Loaded(object sender, RoutedEventArgs e) { Person p = new Person(){Age = 20,Name = "wala"};

        this.XctkPropertyGrid.SelectedObject = p;
    }

[Range (0150, ErrorMessage="Age=0-150")] can prevent users from entering illegal values, but there is no red box mark or error prompt. Debugging found that this [string propertyName] indexer has not been called because it prevents users from entering illegal values.

question2:use person2 insteadof person1,When the user inputs an incorrect value, a red boder will prompt, but when the user leaves the attribute input box, the value in the red boder will return to the legal value, but the red boder will not disappear. public class Person2 : INotifyPropertyChanged, IDataErrorInfo {

    [DisplayName("Name")]
    public string Name { set; get; }

    private int _age;
    [DisplayName("Age")]
    public int Age {
        set
        {
            if (!ValidataProperty(nameof(Age), value))
                return;
                _age = value;
            RaisePropertyChanged(nameof(Age));
        }
         get
        {
            return _age;
        }}

    public event PropertyChangedEventHandler? PropertyChanged;

    [Browsable(false)]
    public string Error { get; }

    protected bool ValidataProperty(string propertyName, object val)
    {

        if (propertyName.Equals(nameof(Age)))
        {
            int ageVal = (int)val;
            if (ageVal < 0 || ageVal > 150)
            {
                ErrorProperty = propertyName;
                ErrorMsg = "Age =0~150";
                return false;
            }

        }

        ErrorMsg = string.Empty;
        ErrorProperty = string.Empty;
        return true;
    }

    private string ErrorProperty;
    private string ErrorMsg;

    public string this[string propertyName]
    {
        get
        {
            if (ErrorProperty.Equals(propertyName))
            {
                return ErrorMsg;
            }

            return string.Empty;
        }
    }

    protected void RaisePropertyChanged([CallerMemberName] string propertyName = null) => this.OnPropertyChanged(new PropertyChangedEventArgs(propertyName));

    protected virtual void OnPropertyChanged(PropertyChangedEventArgs args)
    {
        PropertyChangedEventHandler propertyChanged = this.PropertyChanged;
        if (propertyChanged == null)
            return;
        propertyChanged((object)this, args);
    }
}
zhongruijia commented 8 months ago

这里是郭瑞的邮箱,已收到您的来件,我会尽快拜阅并给予您回复