xcfem / xc

finite element analysis package for civil engineering structures.
http://www.xcengineering.xyz/html_files/software.html
GNU General Public License v3.0
266 stars 54 forks source link

Use a more pythonic way #125

Closed ebrahimraeyat closed 8 months ago

lcpt commented 11 months ago

Thanks, Ebrahim.

Have you checked your code against the verification tests?

ebrahimraeyat commented 11 months ago

No, I will try to compile xc and test it!

lcpt commented 11 months ago

OK, thanks!

lcpt commented 10 months ago

Any news about this?

ebrahimraeyat commented 10 months ago

Thanks @lcpt . I recompiled it today and run tests. some tests fails, I don't think related to this changes:

test test_shell_mitc4_28.py: ok.
test test_shell_mitc9_01.py: ok.
ERROR:root:test_shell_mitc9_02.py ERROR.
ratio1=  nan
RN1=  nan RN2=  nan RN3=  nan RN4=  nan
test test_shell_mitc9_03.py: ok.
test modal_analysis_test_04.py: ok.
test modal_analysis_test_05.py: ok.
XC::SolutionStrategy::alloc_system_of_equations; system of equations: 'spectra_eigen_soe' unknown.
ERROR:root:FrequencyAnalysis.sysOfEqnSetup; could not get a system of equations of type: 'spectra_eigen_soe' probably is not a valid type or it is not implemented in your system.
     Linear buckling analysis tests.
test linear_buckling_column01.py: ok.
test test_paving_02.py: ok.
test test_paving_03.py: ok.
ERROR:root:test_paving_04.py ERROR.
test test_paving_07.py: ok.
test test_gmsh_01.py: ok.
test test_fiber_section_shear3d_01.py: ok.
ERROR:root:test_fiber_section_shear3d_02.py ERROR.
test test_fiber_section_prop.py: ok.
test: test_embankment_02.py: ok.
ERROR:root:test: test_embankment_03.py ERROR.
test: test_embankment_04.py: ok.
test test_simple_beam_oscillation.py: ok.
   Earth retaining structures...
ERROR:root:retaining_wall_test_01.py ERROR.
test retaining_wall_test_02.py: ok.
ebrahimraeyat commented 8 months ago

Hello @lcpt , Any news about this? Is it require something else?

lcpt commented 8 months ago

Thanks @lcpt . I recompiled it today and run tests. some tests fails, I don't think related to this changes:

test test_shell_mitc4_28.py: ok.
test test_shell_mitc9_01.py: ok.
ERROR:root:test_shell_mitc9_02.py ERROR.
ratio1=  nan
RN1=  nan RN2=  nan RN3=  nan RN4=  nan
test test_shell_mitc9_03.py: ok.
test modal_analysis_test_04.py: ok.
test modal_analysis_test_05.py: ok.
XC::SolutionStrategy::alloc_system_of_equations; system of equations: 'spectra_eigen_soe' unknown.
ERROR:root:FrequencyAnalysis.sysOfEqnSetup; could not get a system of equations of type: 'spectra_eigen_soe' probably is not a valid type or it is not implemented in your system.
     Linear buckling analysis tests.
test linear_buckling_column01.py: ok.
test test_paving_02.py: ok.
test test_paving_03.py: ok.
ERROR:root:test_paving_04.py ERROR.
test test_paving_07.py: ok.
test test_gmsh_01.py: ok.
test test_fiber_section_shear3d_01.py: ok.
ERROR:root:test_fiber_section_shear3d_02.py ERROR.
test test_fiber_section_prop.py: ok.
test: test_embankment_02.py: ok.
ERROR:root:test: test_embankment_03.py ERROR.
test: test_embankment_04.py: ok.
test test_simple_beam_oscillation.py: ok.
   Earth retaining structures...
ERROR:root:retaining_wall_test_01.py ERROR.
test retaining_wall_test_02.py: ok.

Those errors are not related with the changes of this PR but, they are strange. The only known error is that of program test_shell_mitc9_02.py (which is an intermittent error), in the rest of the cases no errors should occur. Are you using a 32-bit platform?

ebrahimraeyat commented 8 months ago

I have ubuntu wsl system on windows:

root@DESKTOP-7AJHP3M:~# uname -p
x86_64
lcpt commented 8 months ago

It's strange. Unfortunately, at this moment, I have no access to a WSL machine. I'll take a look when I have the opportunity.