Two method with same names in AISC Member class

xcfem / xc

finite element analysis package for civil engineering structures.

http://www.xcengineering.xyz/html_files/software.html

GNU General Public License v3.0

262 stars 54 forks source link

Two method with same names in AISC Member class #85

Closed ebrahimraeyat closed 3 years ago

ebrahimraeyat commented 3 years ago

It seems two method with the same name in line 142 and 149:

https://github.com/xcfem/xc/blob/5b6d13d06325450efe0159cbcb520273bb353891/python_modules/materials/astm_aisc/AISC_limit_state_checking.py#L142

https://github.com/xcfem/xc/blob/5b6d13d06325450efe0159cbcb520273bb353891/python_modules/materials/astm_aisc/AISC_limit_state_checking.py#L149

lcpt commented 3 years ago

Hi, @ebrahimraeyat. Thanks!

You're right, the first method has the wrong name (it returns the flexural strength reduction factor). I've not detected any calls to this method anywhere so, probably, the problem ends here.