search

xcherryio / sdk-go

Golang SDK for xCherry
Apache License 2.0
1 stars 0 forks source link

Update for breaking changes in command status #28

Closed zklgame closed 10 months ago

zklgame commented 10 months ago

Mainly update for TimerStatus -> Status.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 419 lines in your changes are missing coverage. Please review.

Comparison is base (bd41278) 87.50% compared to head (341d313) 3.07%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================== - Coverage 87.50% 3.07% -84.43% ========================================== Files 1 31 +30 Lines 16 1039 +1023 ========================================== + Hits 14 32 +18 - Misses 1 1003 +1002 - Partials 1 4 +3 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [xdb/client\_options.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL2NsaWVudF9vcHRpb25zLmdv) | `0.00% <ø> (ø)` | | | [xdb/command.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL2NvbW1hbmQuZ28=) | `0.00% <0.00%> (ø)` | | | [xdb/command\_results.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL2NvbW1hbmRfcmVzdWx0cy5nbw==) | `0.00% <0.00%> (ø)` | | | [xdb/worker\_options.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL3dvcmtlcl9vcHRpb25zLmdv) | `0.00% <0.00%> (ø)` | | | [xdb/state\_schema.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL3N0YXRlX3NjaGVtYS5nbw==) | `0.00% <0.00%> (ø)` | | | [xdb/async\_state\_options.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL2FzeW5jX3N0YXRlX29wdGlvbnMuZ28=) | `0.00% <0.00%> (ø)` | | | [xdb/basic\_client\_impl.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL2Jhc2ljX2NsaWVudF9pbXBsLmdv) | `0.00% <0.00%> (ø)` | | | [xdb/process.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL3Byb2Nlc3MuZ28=) | `0.00% <0.00%> (ø)` | | | [xdb/process\_options.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL3Byb2Nlc3Nfb3B0aW9ucy5nbw==) | `0.00% <0.00%> (ø)` | | | [xdb/registry.go](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-eGRiL3JlZ2lzdHJ5Lmdv) | `0.00% <0.00%> (ø)` | | | ... and [11 more](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb-golang-sdk/pull/28/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

longquanzheng commented 10 months ago

lgtm. perhaps you can wait for my big PR to save me from a rebase ><

I just merged mine. You need to rebase (hopefully just the go.mod file need to refresh)