xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

Split configs for cluster + cluster membership #123

Closed zklgame closed 7 months ago

zklgame commented 7 months ago

This MR did:

TODO in other MRs:

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 33.18284% with 296 lines in your changes are missing coverage. Please review.

Project coverage is 59.32%. Comparing base (c5da3b2) to head (d14ef8b).

Files Patch % Lines
service/async/service_impl.go 33.33% 100 Missing and 8 partials :warning:
service/async/membership_impl.go 6.15% 61 Missing :warning:
service/async/event_delegate.go 0.00% 44 Missing :warning:
service/async/delegate.go 0.00% 26 Missing :warning:
service/async/gin_handler.go 21.73% 16 Missing and 2 partials :warning:
config/config.go 78.66% 12 Missing and 4 partials :warning:
service/async/task_notifier_impl.go 0.00% 8 Missing :warning:
engine/timer_task_queue.go 0.00% 6 Missing :warning:
engine/immediate_task_queue.go 0.00% 4 Missing :warning:
engine/immediate_task_concurrent_processor.go 62.50% 3 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ========================================== - Coverage 61.38% 59.32% -2.07% ========================================== Files 88 92 +4 Lines 6936 7255 +319 ========================================== + Hits 4258 4304 +46 - Misses 2404 2668 +264 - Partials 274 283 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.