xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

Refactor for insertAsyncStateExecution and insertWorkerTask functions #35

Closed zklgame closed 11 months ago

zklgame commented 11 months ago

This MR did: Extract common logic used in two places into shared functions and reduce duplication.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (f9b9f61) 58.19% compared to head (39ab66d) 58.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== + Coverage 58.19% 58.70% +0.51% ========================================== Files 38 38 Lines 2332 2315 -17 ========================================== + Hits 1357 1359 +2 + Misses 852 840 -12 + Partials 123 116 -7 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [persistence/sql/sql\_process\_store.go](https://app.codecov.io/gh/xdblab/xdb/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlLmdv) | `67.48% <100.00%> (+1.98%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/35/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.