search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

process id reuse policy #36

Closed duoertai closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (070973a) 57.92% compared to head (f996b57) 66.18%.

:exclamation: Current head f996b57 differs from pull request most recent head 14d12bf. Consider uploading reports for the commit 14d12bf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== + Coverage 57.92% 66.18% +8.26% ========================================== Files 39 39 Lines 2550 3123 +573 ========================================== + Hits 1477 2067 +590 + Misses 959 919 -40 - Partials 114 137 +23 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [engine/worker\_task\_conrrent\_processor.go](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL3dvcmtlcl90YXNrX2NvbnJyZW50X3Byb2Nlc3Nvci5nbw==) | `74.88% <ø> (+8.21%)` | :arrow_up: | | [extensions/postgres/extension.go](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZXh0ZW5zaW9ucy9wb3N0Z3Jlcy9leHRlbnNpb24uZ28=) | `73.33% <ø> (ø)` | | | [extensions/postgres/non\_transactional.go](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZXh0ZW5zaW9ucy9wb3N0Z3Jlcy9ub25fdHJhbnNhY3Rpb25hbC5nbw==) | `100.00% <100.00%> (ø)` | | | [persistence/sql/sqltest/base\_basic.go](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvYmFzZV9iYXNpYy5nbw==) | `100.00% <100.00%> (ø)` | | | [persistence/sql/sqltest/common.go](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvY29tbW9uLmdv) | `100.00% <100.00%> (ø)` | | | [service/api/service\_impl.go](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-c2VydmljZS9hcGkvc2VydmljZV9pbXBsLmdv) | `62.96% <ø> (+22.22%)` | :arrow_up: | | [extensions/postgres/transactional.go](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZXh0ZW5zaW9ucy9wb3N0Z3Jlcy90cmFuc2FjdGlvbmFsLmdv) | `70.66% <73.91%> (+5.85%)` | :arrow_up: | | [persistence/sql/sql\_process\_store.go](https://app.codecov.io/gh/xdblab/xdb/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlLmdv) | `60.34% <51.19%> (+1.70%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/36/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

longquanzheng commented 1 year ago

Very good job on the code quality/readability!