xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

Add comments to config and a minor rename of constructor #37

Closed longquanzheng closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f9b9f61) 58.19% compared to head (f48cc4b) 58.33%. Report is 1 commits behind head on main.

:exclamation: Current head f48cc4b differs from pull request most recent head bf2f156. Consider uploading reports for the commit bf2f156 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================== + Coverage 58.19% 58.33% +0.14% ========================================== Files 38 38 Lines 2332 2321 -11 ========================================== - Hits 1357 1354 -3 + Misses 852 850 -2 + Partials 123 117 -6 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [cmd/server/bootstrap/xdb.go](https://app.codecov.io/gh/xdblab/xdb/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y21kL3NlcnZlci9ib290c3RyYXAveGRiLmdv) | `19.76% <100.00%> (ø)` | | | [config/config.go](https://app.codecov.io/gh/xdblab/xdb/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y29uZmlnL2NvbmZpZy5nbw==) | `44.77% <ø> (ø)` | | | [service/async/service\_impl.go](https://app.codecov.io/gh/xdblab/xdb/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-c2VydmljZS9hc3luYy9zZXJ2aWNlX2ltcGwuZ28=) | `55.00% <100.00%> (ø)` | | | [engine/worker\_task\_queue.go](https://app.codecov.io/gh/xdblab/xdb/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL3dvcmtlcl90YXNrX3F1ZXVlLmdv) | `69.60% <75.00%> (ø)` | | | [cmd/server/main.go](https://app.codecov.io/gh/xdblab/xdb/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y21kL3NlcnZlci9tYWluLmdv) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/37/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.