search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

Merge intervals when committing completed pages #54

Closed zklgame closed 11 months ago

zklgame commented 11 months ago

Why make this pull request?

Merge intervals when committing completed pages

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

codecov[bot] commented 11 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (53f688a) 68.71% compared to head (a26cd94) 67.88%.

:exclamation: Current head a26cd94 differs from pull request most recent head 72441db. Consider uploading reports for the commit 72441db to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== - Coverage 68.71% 67.88% -0.84% ========================================== Files 46 46 Lines 4031 4045 +14 ========================================== - Hits 2770 2746 -24 - Misses 1072 1106 +34 - Partials 189 193 +4 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [engine/worker\_task\_queue.go](https://app.codecov.io/gh/xdblab/xdb/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL3dvcmtlcl90YXNrX3F1ZXVlLmdv) | `57.57% <0.00%> (-6.84%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/54/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.