search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

split sql_process_store into multiple files, remove is_current #60

Closed duoertai closed 11 months ago

duoertai commented 11 months ago

Why make this pull request?

split a large file into smaller ones

What has changed

no logic change

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

no change in logic, just move to other files

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

codecov[bot] commented 11 months ago

Codecov Report

Attention: 273 lines in your changes are missing coverage. Please review.

Comparison is base (752a0c8) 70.32% compared to head (42aaa93) 70.52%.

:exclamation: Current head 42aaa93 differs from pull request most recent head 267ea6c. Consider uploading reports for the commit 267ea6c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ========================================== + Coverage 70.32% 70.52% +0.19% ========================================== Files 46 60 +14 Lines 4064 4057 -7 ========================================== + Hits 2858 2861 +3 + Misses 1021 1013 -8 + Partials 185 183 -2 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [extensions/postgres/non\_transactional.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZXh0ZW5zaW9ucy9wb3N0Z3Jlcy9ub25fdHJhbnNhY3Rpb25hbC5nbw==) | `86.04% <ø> (ø)` | | | [extensions/postgres/transactional.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZXh0ZW5zaW9ucy9wb3N0Z3Jlcy90cmFuc2FjdGlvbmFsLmdv) | `84.00% <ø> (ø)` | | | [persistence/sql/sql\_process\_store.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlLmdv) | `75.00% <ø> (+11.71%)` | :arrow_up: | | [...ersistence/sql/sql\_process\_store\_clean\_up\_tasks.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlX2NsZWFuX3VwX3Rhc2tzLmdv) | `100.00% <100.00%> (ø)` | | | [persistence/sql/sql\_process\_store\_common.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlX2NvbW1vbi5nbw==) | `100.00% <100.00%> (ø)` | | | [...tence/sql/sql\_process\_store\_delete\_worker\_tasks.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlX2RlbGV0ZV93b3JrZXJfdGFza3MuZ28=) | `100.00% <100.00%> (ø)` | | | [...ql\_process\_store\_get\_timer\_tasks\_for\_timestamps.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlX2dldF90aW1lcl90YXNrc19mb3JfdGltZXN0YW1wcy5nbw==) | `80.00% <80.00%> (ø)` | | | [...l\_process\_store\_get\_timer\_tasks\_up\_to\_timestamp.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlX2dldF90aW1lcl90YXNrc191cF90b190aW1lc3RhbXAuZ28=) | `72.72% <72.72%> (ø)` | | | [...e/sql/sql\_process\_store\_describe\_latest\_process.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlX2Rlc2NyaWJlX2xhdGVzdF9wcm9jZXNzLmdv) | `81.81% <81.81%> (ø)` | | | [...sistence/sql/sql\_process\_store\_get\_worker\_tasks.go](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlX2dldF93b3JrZXJfdGFza3MuZ28=) | `81.81% <81.81%> (ø)` | | | ... and [7 more](https://app.codecov.io/gh/xdblab/xdb/pull/60?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/60/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

longquanzheng commented 11 months ago

Can we split for all the APIs to be consistent?