xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

Add local queue message + command request support #63

Closed zklgame closed 11 months ago

zklgame commented 11 months ago

Why make this pull request?

What has changed

How to test this pull request?

https://github.com/xdblab/xdb-java-sdk/pull/9

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

codecov[bot] commented 11 months ago

Codecov Report

Attention: 532 lines in your changes are missing coverage. Please review.

Comparison is base (280ce6e) 70.15% compared to head (b53ebf9) 62.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #63 +/- ## ========================================== - Coverage 70.15% 62.87% -7.29% ========================================== Files 60 62 +2 Lines 4065 4620 +555 ========================================== + Hits 2852 2905 +53 - Misses 1027 1521 +494 - Partials 186 194 +8 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [persistence/sql/backoff\_immediate\_task.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL2JhY2tvZmZfaW1tZWRpYXRlX3Rhc2suZ28=) | `59.09% <100.00%> (-0.62%)` | :arrow_down: | | [persistence/sql/sqltest/base\_backoff.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvYmFzZV9iYWNrb2ZmLmdv) | `100.00% <100.00%> (ø)` | | | [persistence/sql/sqltest/base\_basic.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvYmFzZV9iYXNpYy5nbw==) | `100.00% <100.00%> (ø)` | | | [persistence/sql/sqltest/common.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvY29tbW9uLmdv) | `100.00% <100.00%> (ø)` | | | [service/api/default\_server.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-c2VydmljZS9hcGkvZGVmYXVsdF9zZXJ2ZXIuZ28=) | `94.87% <100.00%> (+0.13%)` | :arrow_up: | | [persistence/sql/prepare\_state.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3ByZXBhcmVfc3RhdGUuZ28=) | `58.62% <66.66%> (-5.38%)` | :arrow_down: | | [persistence/sql/start\_process.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3N0YXJ0X3Byb2Nlc3MuZ28=) | `57.51% <82.35%> (+0.15%)` | :arrow_up: | | [common/uuid/uuid.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y29tbW9uL3V1aWQvdXVpZC5nbw==) | `39.62% <0.00%> (-5.06%)` | :arrow_down: | | [persistence/sql/complete\_execute.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL2NvbXBsZXRlX2V4ZWN1dGUuZ28=) | `63.28% <45.45%> (-3.12%)` | :arrow_down: | | [persistence/data\_models\_enums.go](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHNfZW51bXMuZ28=) | `45.45% <0.00%> (-9.10%)` | :arrow_down: | | ... and [11 more](https://app.codecov.io/gh/xdblab/xdb/pull/63?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/63/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

longquanzheng commented 11 months ago

Ahh great point. We can’t delete it

On Mon, Oct 23, 2023 at 5:30 PM Kaili Zhu @.***> wrote:

@.**** commented on this pull request.

In persistence/data_models_json_fields.go https://github.com/xdblab/xdb/pull/63#discussion_r1369421890:

@@ -139,15 +281,16 @@ type WorkerTaskBackoffInfoJson struct { }

type LocalQueueMessageInfoJson struct {

  • QueueName string json:"queueName"
  • DedupId uuid.UUID json:"dedupId"
  • QueueName string json:"queueName"
  • DedupId uuid.UUID json:"dedupId"
  • Payload xdbapi.EncodedObject json:"payload"

If deleting the row from local queue table, how could we check the duplicated dedupId?

— Reply to this email directly, view it on GitHub https://github.com/xdblab/xdb/pull/63#discussion_r1369421890, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCQPM6VY4HAXUSVQSN37HTYA4DZHAVCNFSM6AAAAAA6KIGWK2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJTG42DQMJUHE . You are receiving this because you commented.Message ID: @.***>