Closed zklgame closed 11 months ago
Attention: 532 lines
in your changes are missing coverage. Please review.
Comparison is base (
280ce6e
) 70.15% compared to head (b53ebf9
) 62.87%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ahh great point. We can’t delete it
On Mon, Oct 23, 2023 at 5:30 PM Kaili Zhu @.***> wrote:
@.**** commented on this pull request.
In persistence/data_models_json_fields.go https://github.com/xdblab/xdb/pull/63#discussion_r1369421890:
@@ -139,15 +281,16 @@ type WorkerTaskBackoffInfoJson struct { }
type LocalQueueMessageInfoJson struct {
- QueueName string
json:"queueName"
- DedupId uuid.UUID
json:"dedupId"
- QueueName string
json:"queueName"
- DedupId uuid.UUID
json:"dedupId"
- Payload xdbapi.EncodedObject
json:"payload"
If deleting the row from local queue table, how could we check the duplicated dedupId?
— Reply to this email directly, view it on GitHub https://github.com/xdblab/xdb/pull/63#discussion_r1369421890, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCQPM6VY4HAXUSVQSN37HTYA4DZHAVCNFSM6AAAAAA6KIGWK2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJTG42DQMJUHE . You are receiving this because you commented.Message ID: @.***>
Why make this pull request?
What has changed
publish to local queue
andprocess local queue messages task
(batch process).How to test this pull request?
https://github.com/xdblab/xdb-java-sdk/pull/9
Checklist before merge
[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update
go.mod
to use the commitID of the main branches for xdb-apis/xdb-golang-sdk