search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

fix no wait until case in failure recovery #70

Closed duoertai closed 10 months ago

duoertai commented 10 months ago

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

codecov[bot] commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3902b7f) 64.16% compared to head (3107a83) 64.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #70 +/- ## ========================================== + Coverage 64.16% 64.41% +0.24% ========================================== Files 64 64 Lines 4923 4935 +12 ========================================== + Hits 3159 3179 +20 + Misses 1557 1549 -8 Partials 207 207 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [integTests/init.go](https://app.codecov.io/gh/xdblab/xdb/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-aW50ZWdUZXN0cy9pbml0Lmdv) | `90.00% <100.00%> (+1.11%)` | :arrow_up: | | [engine/immediate\_task\_conrrent\_processor.go](https://app.codecov.io/gh/xdblab/xdb/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL2ltbWVkaWF0ZV90YXNrX2NvbnJyZW50X3Byb2Nlc3Nvci5nbw==) | `82.15% <72.72%> (-0.31%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/70/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.