search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

use next state config for each next state, fix issue of both task typ… #75

Closed duoertai closed 1 year ago

duoertai commented 1 year ago

…e use wait until retry policy

Why make this pull request?

  1. all state executions are using starting state execution
  2. while processing immediate task, both waituntil and execute are using waituntil retry poicy

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

codecov[bot] commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f0d4592) 64.41% compared to head (e5ded89) 64.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== + Coverage 64.41% 64.57% +0.15% ========================================== Files 64 64 Lines 4935 4943 +8 ========================================== + Hits 3179 3192 +13 + Misses 1549 1546 -3 + Partials 207 205 -2 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [engine/immediate\_task\_conrrent\_processor.go](https://app.codecov.io/gh/xdblab/xdb/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL2ltbWVkaWF0ZV90YXNrX2NvbnJyZW50X3Byb2Nlc3Nvci5nbw==) | `82.25% <91.66%> (+0.10%)` | :arrow_up: | | [persistence/sql/complete\_execute.go](https://app.codecov.io/gh/xdblab/xdb/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL2NvbXBsZXRlX2V4ZWN1dGUuZ28=) | `63.28% <50.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/75/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.