search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

Implement global attributes basic(no locking) #76

Closed longquanzheng closed 10 months ago

longquanzheng commented 10 months ago

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

longquanzheng commented 10 months ago

@duoertai @zklgame not completed yet, but open to any early review 😂 (sorry it took me a long time to get here)

codecov[bot] commented 10 months ago

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (94bb0c5) 64.57% compared to head (774b133) 67.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ========================================== + Coverage 64.57% 67.08% +2.50% ========================================== Files 64 67 +3 Lines 4943 5471 +528 ========================================== + Hits 3192 3670 +478 - Misses 1546 1584 +38 - Partials 205 217 +12 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [extensions/postgres/postgrestool/tool.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZXh0ZW5zaW9ucy9wb3N0Z3Jlcy9wb3N0Z3Jlc3Rvb2wvdG9vbC5nbw==) | `0.00% <ø> (ø)` | | | [integTests/init.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-aW50ZWdUZXN0cy9pbml0Lmdv) | `90.90% <100.00%> (+0.90%)` | :arrow_up: | | [persistence/data\_models.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHMuZ28=) | `25.00% <ø> (ø)` | | | [persistence/data\_models\_json\_fields.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHNfanNvbl9maWVsZHMuZ28=) | `92.11% <100.00%> (+0.86%)` | :arrow_up: | | [...stence/sql/recover\_from\_state\_execution\_failure.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3JlY292ZXJfZnJvbV9zdGF0ZV9leGVjdXRpb25fZmFpbHVyZS5nbw==) | `42.16% <100.00%> (-1.37%)` | :arrow_down: | | [persistence/sql/sql\_process\_store.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbF9wcm9jZXNzX3N0b3JlLmdv) | `75.00% <ø> (ø)` | | | [persistence/sql/sqltest/base\_backoff.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvYmFzZV9iYWNrb2ZmLmdv) | `100.00% <100.00%> (ø)` | | | [persistence/sql/sqltest/base\_basic.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvYmFzZV9iYXNpYy5nbw==) | `100.00% <100.00%> (ø)` | | | [persistence/sql/sqltest/base\_global\_attributes.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvYmFzZV9nbG9iYWxfYXR0cmlidXRlcy5nbw==) | `100.00% <100.00%> (ø)` | | | [persistence/sql/sqltest/base\_recover.go](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2Uvc3FsL3NxbHRlc3QvYmFzZV9yZWNvdmVyLmdv) | `100.00% <100.00%> (ø)` | | | ... and [10 more](https://app.codecov.io/gh/xdblab/xdb/pull/76?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.