search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

add support for process timeout #79

Closed duoertai closed 10 months ago

duoertai commented 10 months ago

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

duoertai commented 10 months ago

in backoff test failure case, the worker backoff timer is not fired before process timeout when it happens the failure doesn't always happen though

codecov[bot] commented 10 months ago

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (bcaacd4) 65.11% compared to head (89b6b05) 65.46%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ========================================== + Coverage 65.11% 65.46% +0.35% ========================================== Files 68 69 +1 Lines 5676 5847 +171 ========================================== + Hits 3696 3828 +132 - Misses 1758 1777 +19 - Partials 222 242 +20 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [cmd/server/bootstrap/xdb.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y21kL3NlcnZlci9ib290c3RyYXAveGRiLmdv) | `19.76% <ø> (ø)` | | | [cmd/server/main.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y21kL3NlcnZlci9tYWluLmdv) | `0.00% <ø> (ø)` | | | [cmd/tools/postgres/main.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y21kL3Rvb2xzL3Bvc3RncmVzL21haW4uZ28=) | `0.00% <ø> (ø)` | | | [common/ptr/any.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y29tbW9uL3B0ci9hbnkuZ28=) | `100.00% <ø> (ø)` | | | [common/urlautofix/autofix.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y29tbW9uL3VybGF1dG9maXgvYXV0b2ZpeC5nbw==) | `45.45% <ø> (ø)` | | | [config/config.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-Y29uZmlnL2NvbmZpZy5nbw==) | `61.05% <ø> (ø)` | | | [engine/backoff.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL2JhY2tvZmYuZ28=) | `82.85% <100.00%> (ø)` | | | [engine/immediate\_task\_conrrent\_processor.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL2ltbWVkaWF0ZV90YXNrX2NvbnJyZW50X3Byb2Nlc3Nvci5nbw==) | `80.60% <ø> (+0.64%)` | :arrow_up: | | [engine/immediate\_task\_queue.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL2ltbWVkaWF0ZV90YXNrX3F1ZXVlLmdv) | `81.88% <ø> (ø)` | | | [engine/timer\_task\_priority\_queue.go](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL3RpbWVyX3Rhc2tfcHJpb3JpdHlfcXVldWUuZ28=) | `92.30% <ø> (ø)` | | | ... and [47 more](https://app.codecov.io/gh/xdblab/xdb/pull/79?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/79/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.