xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

Fix timer queue to reset currentNotifyRequests and fix script to install sample tables #82

Closed longquanzheng closed 10 months ago

longquanzheng commented 10 months ago

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a0adf46) 65.46% compared to head (5a0c3ba) 65.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #82 +/- ## ========================================== + Coverage 65.46% 65.70% +0.23% ========================================== Files 69 69 Lines 5847 5850 +3 ========================================== + Hits 3828 3844 +16 + Misses 1777 1767 -10 + Partials 242 239 -3 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [engine/timer\_task\_queue.go](https://app.codecov.io/gh/xdblab/xdb/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL3RpbWVyX3Rhc2tfcXVldWUuZ28=) | `71.50% <100.00%> (+0.43%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/82/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.