search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

split data_model_json_fields.go into multiple files #92

Closed duoertai closed 12 months ago

duoertai commented 12 months ago

Why make this pull request?

split data_model_json_fields.go into multiple files

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first, without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]

[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR. After the server PR is merged, merge the integration test in the SDK repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

codecov[bot] commented 12 months ago

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (52f5fa0) 65.61% compared to head (ca21b6f) 65.63%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ========================================== + Coverage 65.61% 65.63% +0.01% ========================================== Files 69 77 +8 Lines 5849 5849 ========================================== + Hits 3838 3839 +1 + Misses 1769 1768 -1 Partials 242 242 ``` | [Files](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | Coverage Δ | | |---|---|---| | [engine/immediate\_task\_queue.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL2ltbWVkaWF0ZV90YXNrX3F1ZXVlLmdv) | `81.88% <100.00%> (ø)` | | | [engine/timer\_task\_priority\_queue.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL3RpbWVyX3Rhc2tfcHJpb3JpdHlfcXVldWUuZ28=) | `92.30% <100.00%> (ø)` | | | [engine/timer\_task\_queue.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-ZW5naW5lL3RpbWVyX3Rhc2tfcXVldWUuZ28=) | `71.50% <100.00%> (ø)` | | | [...nce/data\_models/async\_state\_execution\_info\_json.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHMvYXN5bmNfc3RhdGVfZXhlY3V0aW9uX2luZm9fanNvbi5nbw==) | `100.00% <100.00%> (ø)` | | | [persistence/data\_models/command\_results\_json.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHMvY29tbWFuZF9yZXN1bHRzX2pzb24uZ28=) | `100.00% <100.00%> (ø)` | | | [persistence/data\_models/data\_models.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHMvZGF0YV9tb2RlbHMuZ28=) | `25.00% <ø> (ø)` | | | [persistence/data\_models/data\_models\_enums.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHMvZGF0YV9tb2RlbHNfZW51bXMuZ28=) | `50.00% <ø> (ø)` | | | [...ersistence/data\_models/immediate\_task\_info\_json.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHMvaW1tZWRpYXRlX3Rhc2tfaW5mb19qc29uLmdv) | `100.00% <100.00%> (ø)` | | | [...istence/data\_models/process\_execution\_info\_json.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHMvcHJvY2Vzc19leGVjdXRpb25faW5mb19qc29uLmdv) | `100.00% <100.00%> (ø)` | | | [...stence/data\_models/state\_execution\_failure\_json.go](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab#diff-cGVyc2lzdGVuY2UvZGF0YV9tb2RlbHMvc3RhdGVfZXhlY3V0aW9uX2ZhaWx1cmVfanNvbi5nbw==) | `100.00% <100.00%> (ø)` | | | ... and [33 more](https://app.codecov.io/gh/xdblab/xdb/pull/92?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xdblab/xdb/pull/92/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xdblab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

duoertai commented 12 months ago

Actually, maybe the file names can start with “datamodels***” ? Or put them all under a new package? It will be easier to find with others

make sense, I'll create a new package