search

xcherryio / xcherry

server and main repo of xCherry project
Apache License 2.0
26 stars 1 forks source link

delete immediate task on completion #95

Closed duoertai closed 10 months ago

duoertai commented 10 months ago

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first, without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]

[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR. After the server PR is merged, merge the integration test in the SDK repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch [ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch [ ] Update go.mod to use the commitID of the main branches for xdb-apis/xdb-golang-sdk

duoertai commented 10 months ago

tested locally by querying xdb_sys_immediate_tasks

codecov[bot] commented 10 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (689585f) 65.51% compared to head (6cf3f0e) 65.62%.

Files Patch % Lines
persistence/sql/complete_execute.go 57.14% 2 Missing and 1 partial :warning:
persistence/sql/wait_until.go 57.14% 2 Missing and 1 partial :warning:
engine/immediate_task_queue.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #95 +/- ## ========================================== + Coverage 65.51% 65.62% +0.10% ========================================== Files 77 77 Lines 5849 5829 -20 ========================================== - Hits 3832 3825 -7 + Misses 1775 1761 -14 - Partials 242 243 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

longquanzheng commented 10 months ago

we also need to remove the logic of batch delete in immediate_task_queue