xchwarze / ckeditor-phpbb

CKEditor integration for phpBB
4 stars 1 forks source link

Getting CKEditor phpBB Plugin and Media Embed phpBB Plugin working together #2

Closed stephanedaviet closed 2 months ago

stephanedaviet commented 3 months ago

Great addon, much more convenient than a bare BBCode editor for end users.

I'm just trying to make it work with the Media Embed phpBB Plugin. I'm a bit lost on how to achieve this.

First of all, when both CKEditor phpBB Plugin and Media Embed phpBB Plugin are enabled, the last one doesn't work. [media] tags are not interpreted and stay as is in the submitted post.

Then, I've tried to add a custom [media] BBCode, but it doesn't work either. When flagging it as to be displayed on posting, I got the button, but no more luck: it isn't transformed into an embed media. For this specific test, two points:

Last, I also look the Embed Plugin and Semantic Embed Plugin for CKEditor, much more powerful than the YouTube Plugin provided in CKEditor phpBB Plugin. Those plugins are based on the oEmbed convention and the Iframely providing this service. It's quite conflicting with the principle of Media Embed phpBB Plugin as this one is based on a list of websites configured inside phpBB itself.

TLDR; I don't know how to get those two plugins working together.

See also Media embed plugin - CKEditor 4 asking for the same thing.

xchwarze commented 3 months ago

It would be necessary to debug some hours where the error is. As far as I remember (as I actually made this plugin more than 4 years ago and the phpbb validation was completed a few months ago....) the plugin I developed it as simple as possible so it does not affect any third party plugin. My original idea was that this quickly pass the validation and with that feedback make a final and new plugin in ckeditor 5 but now 4 years later and I do not have that time.

So I do not really have space to really debug this case, but if you find how to fix it I can integrate those changes to this repo.