search

xchwarze / ckeditor-phpbb

CKEditor integration for phpBB
4 stars 2 forks source link

Bug fixes #3

Closed Ritchie333 closed 5 months ago

Ritchie333 commented 5 months ago

Convert unicode non-breaking spaces to ASCII spaces on handling a previewed or posted message - without this, the parser doesn't recognise smileys correctly. Redirect drag / drop events to the plupload element if it exists - without this, dragging an image to the edit window embeds it as base64 text, crashing the browser.

xchwarze commented 5 months ago

if you modify smiley.js directly it will overwrite when I upgrade the library. You should download the sources of that component from ckeditor and add the unminified edited version.

Ritchie333 commented 5 months ago

I've come up with a better solution that avoids changing the ckeditor source. It should also have a better chance of not having to be rewritten with an upgrade to CKEditor5 (if that ever happens).

The alternative solution is, when getting the returned data from the editor window, identify smileys without a leading space, and add them where appropriate.

xchwarze commented 5 months ago

added to 1.7.0