search

xclud / flutter_crop

Crop any widget/image in Android, iOS, Web and Desktop with fancy and customizable UI, in pure Dart code.
https://pub.dev/packages/crop
MIT License
257 stars 84 forks source link

add preview oval #20

Closed songfei closed 4 years ago

songfei commented 4 years ago

implemented this issue #18

songfei commented 4 years ago

modify the variable name

xclud commented 4 years ago

@songfei i run your PR on my local device. It turned out the changes you've made are not enough to make the oval shape work. Specially in CropRenderObjectWidget and its updateRenderObject some changes are needed.

I completed the missing part and the oval shape is working now. I close this PR without merging t, but i credit you in the CHANGELOG.md as i am inspired by your PR.

Thank You.

songfei commented 4 years ago

@xclud I have used your components in my app. Thank you very much for your work.