Closed sanjul closed 4 years ago
Hi @xclud
This is a fresh PR after closing my outdated PR for the same thing, that gathered dust and conflicts during its time sitting there 😅
You have done amazing work with this plugin ❤️ 💯 I'm using flutter_crop in an app I'm working on; also having a gesture rotate makes so much difference for my use case at least!
Not to hurry, but kindly let know if this looks good, that'll be helpful.
Thank you!
Hi @sanjul ,
I appreciate your great work. Could you please create separate PRs for each feature? you may fork the project and give it a branch name (e.g. add-update-callback
or rotation-gesture
).
Also, updatedCallback
name does not follow flutter's best examples. I suggest onChanged
for its name.
Thanks.
Hi @xclud
Thank you for the feedback! really appreciate it!
Closing this PR, Created separate PRs for each feature (https://github.com/xclud/flutter_crop/pull/31 and https://github.com/xclud/flutter_crop/pull/32 )
Also have made the suggested change and some more!
Thanks
Two finger rotation gesture support
udpatedCallback
on the controller, which if provided, would get triggered withonScaleUpdate
-- this can be used to keep the rotation slider in sync with the two finger rotation!Example:
updatedCallback
is ofcourse, optional.