xclud / web3dart

Ethereum library, written in Dart.
https://pub.dev/packages/web3dart
MIT License
170 stars 94 forks source link

Transaction value property can be null but it's not compatible with some EVM Wallets #147

Open redDwarf03 opened 1 month ago

redDwarf03 commented 1 month ago

Hello

The transaction's value is null by default. For example, Phantom wallet send an RPC error "got code 9991 with msg "Missing or invalid parameters" when value is null. We should send EtherAmount.zero instead of null

Do you think it will be ok to replace null to 0 by default ? Any impact with other wallet ?

I precise i use for example eth_sendTransaction with a Transaction.value = null to create HTLC Contract