Closed semi-h closed 5 months ago
I did some further tests and with the last 2 commits in the PR, running fprettify in the whole codebase doesn't introduce any errors or changes, meaning that the current state is fully compatible with our fprettify settings. Also, I wasn't able to observe any buggy indentation anywhere in the codebase in its current state. To get here:
!&
in every single CUDA kernel call to disable fprettify for that particular line.Although I haven't observed any buggy indentation in the current state, there are two things we need to be aware of
!!
to add in-code documentation via ford, and fprettify doesn't touch any line that starts with !!
. This means user is fully responsible setting the correct indentation for these lines.!&
in every single kernel call, so that fprettify is deactivated and the style/indentation on that particular line is ignored. This is not ideal but only way if we want to have fprettify doing checks/changes automatically in a reliable way.We probably want to update the documentation/coding style to mention the !&
syntax and the change to 2 spaces instead of 3
Added !&
to the documentation. For the style preferences documentation refers to .fprettify.ini in the root folder, doesn't explicitly state the indentation level.
Just wanted to see how fprettify would handle what we want. Only changed the indentation in our config file and run the fprettify in place. I think fprettify gets very annoyed when line length is > 79, and results in a funny indentation.
And fprettify doesn't touch comments starting with
!!
, so almost all of them are wrongly indented.