xcompact3d / x3d2

https://xcompact3d.github.io/x3d2
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Implement OMP backend for basic math operators #93

Closed CFD-Xing closed 2 months ago

CFD-Xing commented 3 months ago

Currently OMP backend for basic math operators such as vecadd is not yet implemented. OMP backend implementation is necessary for testing of the time integrator, for example.

pbartholomew08 commented 2 months ago

Just to check, the missing operators are: 1) sum_<y|z>intox 2) vecadd 3) scalar_product ?

Happy to take a turn at this - is there anything else missing?

semi-h commented 2 months ago

I think these are all the basic ones missing. The only thing to keep in mind is reorder interface in the OpenMP backend do not support reorderings to and from cartesian data structure yet. If you're using get_field_data or set_field_data they require these currently unsupported reordering directions with their default arguments.

Nanoseb commented 2 months ago

The only thing to keep in mind is reorder interface in the OpenMP backend do not support reorderings to and from cartesian data structure yet. If you're using get_field_data or set_field_data they require these currently unsupported reordering directions with their default arguments.

Ah yes, I realised that the other day. I am going to implement it as that's indeed missing and should be easy to do.

Nanoseb commented 2 months ago

see #101 for the reordering ones

pbartholomew08 commented 2 months ago

Closed by #103