search

xcore / tool_axe

An XCore Emulator
Other
15 stars 8 forks source link

add OSCALL_ARGV handling #12

Closed ghost closed 10 years ago

ghost commented 10 years ago

hi richard, OSCALL_ARGV handling Robert

ghost commented 10 years ago

I am pondering if r2 should specify length of buffer in bytes instead of words. I also need to improve the test to check for the trailing null and packing of the strings after the argv[]

rlsosborne commented 10 years ago

I agree specifying size in bytes would slightly better, and the test needs to check argv[argc] == NULL. Could you also wrap the code to 80 columns to match the code around it.

Looks good to merge with these changes.

ghost commented 10 years ago

Hi Richard,

I assume the symbol will be harmless ignored for current builds. With my newer crt1.S, it prevents the crt1.S's OSCALL_ARGV failing due to its buffer being too small.

However, should I have used a preceding '_' for the symbol? viz: "_CmdLineWords"