search

xcoreplatform / magento2-substituteorders

GNU General Public License v3.0
3 stars 9 forks source link

Error can't be translated, because of product name in message #41

Closed pstuifzand closed 1 year ago

pstuifzand commented 3 years ago

On this line https://github.com/dealer4dealer/magento2-substituteorders/blob/009492983be69f4b030a37b0015527134de353f0/Controller/Order/Reorder.php#L143 the error can't be translated, because of the product name in de message. You would need a translation for every product name.

This is the patch we use to fix this.

$errors[] = __("We can\'t add %1 to your shopping cart right now.", $product->getName());
doldersma commented 1 year ago

Hi, thank you for pointing this out, we will apply this patch in version 1.0.27. Also in the same file on line 188.