feat: keep 'sched-gran' grub entry on upgrade

xcp-ng / host-installer_old

XCP-ng installer

16 stars 15 forks source link

feat: keep 'sched-gran' grub entry on upgrade #21

Closed benjamreis closed 4 years ago

benjamreis commented 4 years ago

Goes with https://github.com/xcp-ng/xcp/issues/407

benjamreis commented 4 years ago

Do not merge after validation I wan a second review.

Tested scenarii:

upgrade 8.1 -> 8.2 with sched-gran in grub.cfg
upgrade 8.1 -> 8.2 without sched-gran in grub.cfg
fresh 8.2 install

stormi commented 4 years ago

Looks good. Have you had a look at how answerfiles are handled, so that we now whether your changes magically added support for defining shed-gran in an answerfile, or additional changes would be needed to add that?

benjamreis commented 4 years ago

No didn't have time to look into answerfiles. :/

stormi commented 4 years ago

I had a look myself. Answer file keys must be declared in answerfile.py so it won't be magically supported.