search

xcp-ng / host-installer_old

XCP-ng installer
16 stars 15 forks source link

Copy `grubx64.efi` into `EFI/boot/` #29

Closed benjamreis closed 3 years ago

benjamreis commented 3 years ago

Some firmware needs to have a fallback efi binary in the EFI/boot directory and will fail to boot if not. See: https://xcp-ng.org/forum/topic/4690/host-not-booting-after-install-uefi/

Signed-off-by: BenjiReis benjamin.reis@vates.fr

benjamreis commented 3 years ago

Solves https://github.com/xcp-ng/xcp/issues/502

benjamreis commented 3 years ago

Tested and validated, ready for review and merge :)

benjamreis commented 3 years ago

Yes it does, because when building the grubx64.efi binary it is told to the binary to look for its config in .../EFI/xenserver But we decided to change our approach and do the fix in the RPM instead. It will prevent a desync between the 2 binaries when the grub rpm is upgraded :)

benjamreis commented 3 years ago

The fix will instead be here https://github.com/xcp-ng-rpms/grub/pull/1