search

xcp-ng / xcp-ng-org

XCP-ng org website
69 stars 92 forks source link

Fix network section title #233

Closed bleader closed 1 year ago

bleader commented 1 year ago

I'm unsure about the title level needed here, but it seems likely to be 3 just like the Network objects part.

Before submitting the pull request, you must agree with the following statements by checking both boxes with a 'x'.

  • [x] "I accept that my contribution is placed under the CC BY-SA 2.0 license [1]."
  • [x] "My contribution complies with the Developer Certificate of Origin [2]."

[1] https://creativecommons.org/licenses/by-sa/2.0/ [2] https://xcp-ng.org/docs/contributing.html#developer-certificate-of-origin-dco

stormi commented 1 year ago

I think this PR is good as is, but the the whole document structure might need to be improved to make it clearer.

bleader commented 1 year ago

As discussed with stormi, I added a small improvement in the tip at the top of the page.

bleader commented 1 year ago

Two last pushes were just rewording commit messages to have more context of where these changes were made, content didn't move. I'll assume the approve still stand and merge.

stormi commented 1 year ago

@olivierlambert will you replicate to the new doc, or do you want a PR to the new doc too?