search

xcp-ng / xcp-ng-xapi-plugins

XCP-ng's specific XAPI plugins
GNU Affero General Public License v3.0
7 stars 9 forks source link

Support additional repos in updater plugin #29

Closed Wescoeur closed 3 years ago

stormi commented 3 years ago

What tests have you done besides the unit tests?

Wescoeur commented 3 years ago

I haven't updated the xcp-ng-tests repo, the tests concerning the updater are already minimal, and it is not easy to enrich them. Maybe we should have a specific repo for the tests with fake packages to install?

stormi commented 3 years ago

I haven't updated the xcp-ng-tests repo, the tests concerning the updater are already minimal, and it is not easy to enrich them. Maybe we should have a specific repo for the tests with fake packages to install?

We could indeed, this would be a good idea.

BTW did you test manually on a pool?

benjamreis commented 3 years ago

Can you add a unit tests that uses your new arg?

Wescoeur commented 3 years ago

I added unit tests in this PR. Regarding xcp-ng-tests, I will create a card for that.

stormi commented 3 years ago

I don't think you answered to this yet :)

BTW did you test manually on a pool?

Wescoeur commented 3 years ago

I don't think you answered to this yet :)

Tested on a new pool. :wink:

stormi commented 3 years ago

Looks good to me. Will approve when I see the xcp-ng-tests card targeted at 8.3beta

Wescoeur commented 3 years ago

Updated. :+1: