search

xcpretty / xcode-install

🔽 Install and update your Xcodes
https://fastlane.tools
MIT License
2.59k stars 243 forks source link

Add a system to track the progress of Xcode downloads #278

Closed KrauseFx closed 6 years ago

KrauseFx commented 6 years ago
screenshot 2018-05-10 05 37 31

This was a lot more difficult than expected, the comments in the code should explain everything 👍

This allows us to pass a progress_block to stay up to date on the installation progress of Xcode

Closes https://github.com/KrauseFx/xcode-install/issues/276

segiddins commented 6 years ago

This is a big change to not be adding test coverage for

KrauseFx commented 6 years ago

Yes, happy to add tests, what's the most meaningful way to do so? Stub the Open3.popen3 calls, return objects and stub their methods also?

segiddins commented 6 years ago

Stub the Open3.popen3 calls

that would work. you'd also want to write to the file and ensure that the progress is properly parsed

KrauseFx commented 6 years ago

Cool, thanks for all your feedback @segiddins, really appreciate your help on this. I'll update the PR to address all your comments, as well as add multiple tests 👍