search

xcpretty / xcode-install

🔽 Install and update your Xcodes
https://fastlane.tools
MIT License
2.58k stars 237 forks source link

Migrate to CircleCI 2.0 #330

Closed lokst closed 5 years ago

lokst commented 5 years ago

Builds upon the CircleCI 2.0 config in https://github.com/xcpretty/xcode-install/pull/313 and resolves the issue mentioned in https://github.com/xcpretty/xcode-install/pull/313 by configuring a default login shell to make sure that ~/.bash_profile, which sets up chruby hooks, is sourced.

lokst commented 5 years ago

@KrauseFx I noticed that the build of my PR (https://circleci.com/gh/xcpretty/xcode-install/107) did not run due to the project not having a macOS plan yet. I'm from CircleCI Support and if you like, I can enable one for you, for OSS projects.

KrauseFx commented 5 years ago

@lokst sounds great, yes, please go ahead and enable macOS support 👍

segiddins commented 5 years ago

@lokst it’d be great if you could push another commit, so we can see CI run?

lokst commented 5 years ago

@KrauseFx I've enabled the macOS support 👍 @segiddins I pushed a new commit and the build was successful: https://circleci.com/gh/xcpretty/xcode-install/108 :)

lokst commented 5 years ago

New build here: https://circleci.com/gh/xcpretty/xcode-install/109

kenchan0130 commented 5 years ago

Thank you for your patch. Looks to me good.