search

xcpretty / xcode-install

🔽 Install and update your Xcodes
https://fastlane.tools
MIT License
2.58k stars 237 forks source link

Fixed loading of Fastlane::Actions::VerifyBuildAction #338

Closed salmanasiddiqui closed 5 years ago

salmanasiddiqui commented 5 years ago

This MR fixes various issues in the current master branch (commit#054d80a):

Currently on master branch the xcode install is failing cause constant Fastlane::Actions::VerifyBuildAction is not found. Reason: requiring 'fastlane/actions/actions_helper' doesn't load actions automatically. We need to call Fastlane::Actions.load_default_actions to load all actions.

instead of loading all actions, I decided to just load verify_build action. Loading verify_build also requires fastlane/action, hence we are loading fastlane/action first, and then fastlane/action/verify_build.

There were two more bugs:

  1. In verify_app_cert function, Pathname obj being passed to VerifyBuildAction.get_cert_info. Which resulted in error cause VerifyBuildAction.get_cert_info expects string obj.
  2. cert verification is failing when xcode is not installed from AppStore. My fix is only valid for xcode 8 and onwards. Older versions of xcode have teamIdentifier=not set. I think the best way to do this is to use VerifyXcodeAction instead of VerifyBuildAction
salmanasiddiqui commented 5 years ago

@jpsim Hey apologies for tagging you like this, but seeing your response on other MR of mine I thought it would be good if you can look into this too.

Thanks