search

xcpretty / xcode-install

🔽 Install and update your Xcodes
https://fastlane.tools
MIT License
2.58k stars 237 forks source link

Using Fastlane::Actions::VerifyXcodeAction for verify_app_cert #361

Closed Kesin11 closed 4 years ago

Kesin11 commented 4 years ago

fix #360

Current version of xcode-install (v2.6.1) can not install Xcode 10.x due to verify certificate step.

In #338 @salmanasiddiqui suggested using VerifyXcodeAction instead of VerifyBuildAction. I tried his suggest and it works.

I confirmed in my forked repositories that this code fix can actually install Xcode 10.x. https://github.com/Kesin11/xcode-install/runs/276027924

However, I know this fix is not better because it will be more dependent on fastlane. In addition, additional logs that from VerifyXcodeAction have been displayed.

Another choice is only copy accepted codesign sets from verify_xcode.rb. Which choice should I take?

Vyazovoy commented 4 years ago

It is reasonable to keep verification logic in one well maintained place (Fastlane). Also your PR makes code easier to understand 👍

milch commented 4 years ago

@marcomorain I updated the code in-place, if you could take a look to make sure everything is alright, that'd be great

@Kesin11 Thanks for the fix!

KirkMartinez commented 4 years ago

This may not be a complete fix. I now get this message during validation /Applications/Xcode-10.2.1.app: unsealed contents present in the bundle root

Kesin11 commented 4 years ago

@KirkMartinez In my newest result of installing Xcode shows Xcode 10.2.1 can be installed 👍 My fork repository includes this patch. https://github.com/Kesin11/xcode-install/runs/284517840

Kesin11 commented 4 years ago

Please someone review or merge it. @milch @marcomorain Can you merge this pull-request?

milch commented 4 years ago

Apologies, I think this is probably fine to merge. In my testing installing Xcode 10.2.1 also worked, so I think there must be some other reason why it was not working for @KirkMartinez

milch commented 4 years ago

@Kesin11 Your end to end test setup looks pretty sweet, do you want to submit a PR for that as well?

Kesin11 commented 4 years ago

@milch Thanks for merge! OK I'll submit a PR. I'm sure that test code will help developing xcode-install. But of course, it needs AppleID that has disabled 2FA. Someone have to prepare AppleID.

joshdholtz commented 4 years ago

Popping a new release with this in it in a bit!

joshdholtz commented 4 years ago

Released in 2.6.3 💪