search

xcpretty / xcode-install

🔽 Install and update your Xcodes
https://fastlane.tools
MIT License
2.59k stars 243 forks source link

Add end to end `xcversion install` test. #365

Closed Kesin11 closed 5 years ago

Kesin11 commented 5 years ago

ref #361

Add end to end test with GitHub Actions. It checks xcversion install works properly with several Xcode versions.

If you want to check result of this test, you can see it in my forked repository. https://github.com/Kesin11/xcode-install/pull/4

@milch or someone who has admin access to this repository please do setup for enable this test.

  1. Enable GitHub Actions. This feature is still beta.
  2. Get an AppleID with 2FA disabled.
  3. Set XCODE_INSTALL_USER and XCODE_INSTALL_PASSWORD to repository secrets.
milch commented 5 years ago

Thanks for the PR! 🥇 This will really help increase our confidence in the PRs we get here. I have push access but I’m not actually an admin so I can’t enable GitHub Actions. @joshdholtz help?

IIRC for the downloads you just need any old Apple ID, so we could probably create one that’s throwaway with 2FA disabled

joshdholtz commented 5 years ago

@milch You are now an admin 😊 Feel free to DM me on Twitter if you need something faster in the future 😉

milch commented 5 years ago

Awesome, thanks! I'll merge this now and set up the Apple ID.

Thanks again @Kesin11!