search

xcpretty / xcode-install

🔽 Install and update your Xcodes
https://fastlane.tools
MIT License
2.58k stars 237 forks source link

Revert e2e test and run spec on Github Actions #385

Closed Kesin11 closed 4 years ago

Kesin11 commented 4 years ago

fix #383

Currently, the E2E test is not working properly and always failing. So I'd like to stop using it and instead run the specs that previously run on CircleCI. It will help us to develop xcode-install. I don't know thy test has not been running in CircleCI recently, but GitHub Actions can be used as an alternative.

I tried to run ci.yml on my forked repository (https://github.com/Kesin11/xcode-install/pull/6) and found some issues.

"fetch" test failed randomly on CI. It works on my machine, but not on GitHub Actions. I commented out it to stabilize the behavior of CI. And rubcop shows some violations. I just fix it with rubocop --auto-correct

Kesin11 commented 4 years ago

@milch @jpsim Would you please review it?

milch commented 4 years ago

Looks reasonable, we can investigate why those other tests failed at some point later

milch commented 4 years ago

Thanks for keeping tabs on this! 🚀