search

xcpretty / xcode-install

🔽 Install and update your Xcodes
https://fastlane.tools
MIT License
2.59k stars 243 forks source link

Sort Xcode version by most recent #393

Closed pietbrauer closed 4 years ago

pietbrauer commented 4 years ago

This prevents installing a GM or Beta version if the final version is already published.

The date parsing was also broken. The API returns "05/20/20 11:45" this would result in to_i being 11 which I found useless.

The only tests failing are the ones for the scraping. Are those needed anymore? Beta and GMs are included in the JSON. I am not sure on how to update the fixtures.

pietbrauer commented 4 years ago

This is finally green 🟢

justindhill commented 4 years ago

Thanks for doing this @pietbrauer - would love to see it merged. This caused issues for us when upgrading our CI farm to 11.5.

pietbrauer commented 4 years ago

@justindhill Thanks! Did you try it out and could confirm that it works for you, too?

rpassis commented 4 years ago

@pietbrauer I tested and it works as expected, thanks so much for working on this.

@joshdholtz Could we pretty please find a way to merge and release this soon? Right now if I try to install a non beta version of Xcode i.e. xcversion install 11.5 it will silently install the beta version with no indication that this is the case (other than the build version mismatch at the end of the installation).

Happy to help in any way I can.

Thanks ♥️

joshdholtz commented 4 years ago

Yeah yeah! Pulling laptop out now to test and then I’ll merge and push out a new version!

Will try to get it out by EOD 💪