search

xcpretty / xcode-install

🔽 Install and update your Xcodes
https://fastlane.tools
MIT License
2.58k stars 237 forks source link

Fix Xcode download URL #478

Open Nezz opened 8 months ago

Nezz commented 8 months ago

The URL was broken sometime this summer. I have verified that the suggested workaround in https://github.com/xcpretty/xcode-install/issues/476#issuecomment-1669371090y works on our machines and submitted it as a PR. Credits belongs to @bmarkowww.

Fixes https://github.com/xcpretty/xcode-install/issues/476

rogerluan commented 8 months ago

@Nezz Thank you for this PR, but unfortunately we're under a sunset period. Please refer to https://github.com/xcpretty/xcode-install/blob/master/MIGRATION.md

Moreover, xcodes uses this same URL https://github.com/XcodesOrg/xcodes/blob/71e97f8103fe484c4b28a81191e75b41498152d1/Sources/XcodesKit/URLRequest%2BApple.swift#L6C16-L6C29 and works just fine, so not sure if that's really what's causing the issue here?

Nezz commented 8 months ago

@Nezz Thank you for this PR, but unfortunately we're under a sunset period. Please refer to https://github.com/xcpretty/xcode-install/blob/master/MIGRATION.md

We are still using xcode-install because it works with accounts that don't have 2FA, whereas I couldn't get that working with xcodes. One less fix I guess before we need to switch to xcodereleases.com?

Moreover, xcodes uses this same URL https://github.com/XcodesOrg/xcodes/blob/71e97f8103fe484c4b28a81191e75b41498152d1/Sources/XcodesKit/URLRequest%2BApple.swift#L6C16-L6C29 and works just fine, so not sure if that's really what's causing the issue here?

I'm not sure how it works there, I checked and it is returning a "not found" HTML.

image