Closed ruchimotwaniBC closed 1 year ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
c1e0b76
) 93.30% compared to head (0f33596
) 93.30%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
More of a comment than a full review: We have a module constants.py. It would be best to declare the CRS85 string there once and then have every place that requires it import it. If there ever would be another change, we would then just have to change the one place.
In principle I agree that this would have been preferable, but I don't think that it's worth the additional effort to optimize it now. This PR already introduces module-level constants, which is at least a start. In the unlikely event that the identifier changes again, we can optimize to a global constant at that point.
[Description of PR] Solves #869, the issue of gdal version.
Checklist:
CHANGES.md