search

xd009642 / coveralls-api

Rust implementation of the coveralls api. Allows you to send coveralls reports to coveralls.io
Apache License 2.0
2 stars 2 forks source link

Switch from curl to reqwest for HTTP requests #10

Closed sseemayer closed 1 year ago

sseemayer commented 1 year ago

Closes #9

Instead of using the curl crate that requires compiled-in curl libraries, this PR switches the used HTTP client to the reqwest crate.

I was able to successfully pass all tests on my fork after setting up a coveralls token.

Note: It might make sense to refactor the crate API in a follow-up PR - having a separate upload_status function to check whether the upload was successful instead of returning the status of the HTTP request from the send_to_* methods seems more cumbersome than needed.

BREAKING CHANGES:

  1. the error type returned by the send_to_coveralls and send_to_endpoint functions has changed from curl::Error to reqwest::Error.
  2. (CoverallsReport private fields have changed)
sseemayer commented 1 year ago

@xd009642 let me know what you think. I am also happy to make additional adjustments.